Code Smell Feature Envy
Signs and Symptoms
A method accesses the data of another object more than its own data.
Reasons for the Problem
This smell may occur after fields are moved to a data class. If this is the case, you may want to move the operations on data to this class as well.
As a basic rule, if things change at the same time, you should keep them in the same place. Usually data and functions that use this data are changed together (although exceptions are possible).
- If a method clearly should be moved to another place, use Move Method.
- If only part of a method accesses the data of another object, use Extract Method to move the part in question.
- If a method uses functions from several other classes, first determine which class contains most of the data used. Then place the method in this class along with the other data. Alternatively, use Extract Method to split the method into several parts that can be placed in different places in different classes.
- Less code duplication (if the data handling code is put in a central place).
- Better code organization (methods for handling data are next to the actual data).
When to Ignore
- Sometimes behavior is purposefully kept separate from the class that holds the data. The usual advantage of this is the ability to dynamically change the behavior (see Strategy, Visitor and other patterns).
Tired of reading?
No wonder, there are 7 hours worth of the text on this website.
Try our interactive course on refactoring. It offers less boring approach to learning new stuff.Let's see...