Refactoring Remove Middle Man
A class has too many methods that simply delegate to other objects.
Delete these methods and force the client to call the end methods directly.
To describe this technique, we will use the terms from Hide Delegate, which are:
- Server is the object to which the client has direct access.
- Delegate is the end object that contains the functionality needed by the client.
There are two types of problems:
- The server-class does not do anything itself and simply creates needless complexity. In this case, give thought to whether this class is needed at all.
- Every time a new feature is added to the delegate, you need to create a delegating method for it in the server-class. If a lot of changes are made, this will be rather tiresome.
How to Refactor
- Create a getter for accessing the delegate-class object from the server-class object.
- Replace calls to delegating methods in the server-class with direct calls for methods in the delegate-class.
Tired of reading?
No wonder, there are 7 hours worth of the text on this website.
Try our interactive course on refactoring. It offers less boring approach to learning new stuff.Let's see...