Refactoring Split Temporary Variable
ProblemYou have a local variable that is used to store various intermediate values inside a method (except for cycle variables).
SolutionUse different variables for different values. Each variable should be responsible for only one particular thing.
double temp = 2 * (height + width); System.out.println(temp); temp = height * width; System.out.println(temp);
final double perimeter = 2 * (height + width); System.out.println(perimeter); final double area = height * width; System.out.println(area);
double temp = 2 * (height + width); Console.WriteLine(temp); temp = height * width; Console.WriteLine(temp);
readonly double perimeter = 2 * (height + width); Console.WriteLine(perimeter); readonly double area = height * width; Console.WriteLine(area);
$temp = 2 * ($this->height + $this->width); print($temp); $temp = $this->height * $this->width; print($temp);
$perimeter = 2 * ($this->height + $this->width); print($perimeter); $area = $this->height * $this->width; print($area);
temp = 2 * (height + width) print(temp) temp = height * width print(temp)
perimeter = 2 * (height + width) print(perimeter); area = height * width print(area)
If you are skimping on the number of variables inside a function and reusing them for various unrelated purposes, you are sure to encounter problems as soon as you need to make changes to the code containing the variables. You will have to recheck each case of variable use to make sure that the correct values are used.
Each component of the program code should be responsible for one and one thing only. This makes it much easier to maintain the code, since you can easily replace any particular thing without fear of unintended effects.
Code becomes more readable. If a variable was created long ago in a rush, it probably has a name that does not explain anything:
value, etc. But you can fix this situation by naming the new variables in an understandable, self-explanatory way. Such names might resemble
clientSalutationStringand the like.
This refactoring technique is useful if you anticipate using Extract Method later.
How to Refactor
Find the first place in the code where the variable is given a value. Here you should rename the variable with a name that corresponds to the value being assigned.
Use the new name instead of the old one in places where this value of the variable is used.
Repeat as needed for places where the variable is assigned a different value.
Tired of reading?
No wonder, there are 7 hours worth of the text on this website.
Try out something different. We've just launched the interactive learning course on refactoring. It has more content and much more fun than a boring text.Learn more...
Everything is quite simple. This example is like video (but much cooler):
- After pressing the Play button, you will see floating messages, which will guide you through the example. You can proceed by clicking on them.
- You can fast-forward or return to previous steps by pressing arrow buttons on the left.
- Also, you can take a look at the code diff window, which will show what has changed in code during the example ()
- To check the code for errors, you can press "Compile and test" button ()